From d75b76dbb9e87d5f64bb0271cc318e7be7e84e12 Mon Sep 17 00:00:00 2001
From: ZacharyZcR <zacharyzcr1984@gmail.com>
Date: Sun, 5 Oct 2025 20:40:45 +0800
Subject: [PATCH] fix: clean up empty blocks and unused variables in backend
 utils
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

修复了后端工具文件中的空块和未使用的变量：
- auth-manager.ts: 移除空 else 块
- system-crypto.ts: 修复空 catch 块并添加注释
- starter.ts: 修复空 catch 块并添加注释
- server-stats.ts: 将未使用的 reject 参数重命名为 _reject
- credentials.ts: 将 connectionTimeout 从 let 改为 const

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 src/backend/database/routes/credentials.ts | 3 +--
 src/backend/ssh/server-stats.ts            | 2 +-
 src/backend/starter.ts                     | 4 +++-
 src/backend/utils/auth-manager.ts          | 1 -
 src/backend/utils/system-crypto.ts         | 4 +++-
 5 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/backend/database/routes/credentials.ts b/src/backend/database/routes/credentials.ts
index 38614195..86a46705 100644
--- a/src/backend/database/routes/credentials.ts
+++ b/src/backend/database/routes/credentials.ts
@@ -1124,9 +1124,8 @@ async function deploySSHKeyToHost(
 ): Promise<{ success: boolean; message?: string; error?: string }> {
   return new Promise((resolve) => {
     const conn = new Client();
-    let connectionTimeout: NodeJS.Timeout;
 
-    connectionTimeout = setTimeout(() => {
+    const connectionTimeout = setTimeout(() => {
       conn.destroy();
       resolve({ success: false, error: "Connection timeout" });
     }, 120000);
diff --git a/src/backend/ssh/server-stats.ts b/src/backend/ssh/server-stats.ts
index f580bb96..1dfd27e3 100644
--- a/src/backend/ssh/server-stats.ts
+++ b/src/backend/ssh/server-stats.ts
@@ -60,7 +60,7 @@ class SSHConnectionPool {
       return client;
     }
 
-    return new Promise((resolve, reject) => {
+    return new Promise((resolve, _reject) => {
       const checkAvailable = () => {
         const available = connections.find((conn) => !conn.inUse);
         if (available) {
diff --git a/src/backend/starter.ts b/src/backend/starter.ts
index fb0cfc89..a7244082 100644
--- a/src/backend/starter.ts
+++ b/src/backend/starter.ts
@@ -21,7 +21,9 @@ import { systemLogger, versionLogger } from "./utils/logger.js";
       if (persistentConfig.parsed) {
         Object.assign(process.env, persistentConfig.parsed);
       }
-    } catch {}
+    } catch {
+      // Ignore errors if .env file doesn't exist
+    }
 
     let version = "unknown";
 
diff --git a/src/backend/utils/auth-manager.ts b/src/backend/utils/auth-manager.ts
index 541d889f..e85bae28 100644
--- a/src/backend/utils/auth-manager.ts
+++ b/src/backend/utils/auth-manager.ts
@@ -108,7 +108,6 @@ class AuthManager {
 
       if (migrationResult.migrated) {
         await saveMemoryDatabaseToFile();
-      } else {
       }
     } catch (error) {
       databaseLogger.error("Lazy encryption migration failed", error, {
diff --git a/src/backend/utils/system-crypto.ts b/src/backend/utils/system-crypto.ts
index cd805bfc..ea0ab8ef 100644
--- a/src/backend/utils/system-crypto.ts
+++ b/src/backend/utils/system-crypto.ts
@@ -37,7 +37,9 @@ class SystemCrypto {
           process.env.JWT_SECRET = jwtMatch[1];
           return;
         }
-      } catch {}
+      } catch {
+        // Ignore file read errors, will generate new secret
+      }
 
       await this.generateAndGuideUser();
     } catch (error) {