v1.7.3 #390

2025-10-09T04:40:40Z

LukeGus commented

2025-10-09 04:40:40 +00:00

(Migrated from github.com)

Updated terminal font, fixed password reset issues, and added a German language option

Update Log:

Replaced JetBrains Mono with CaskaydiaCove Mono
Added option for German
Made both sidebar states persist

Bug Fix:

Fixed the issue where the built-in Termix alert system does not display
Fixed credentials getting reset if you reset your password

Updated terminal font, fixed password reset issues, and added a German language option Update Log: - Replaced JetBrains Mono with CaskaydiaCove Mono - Added option for German - Made both sidebar states persist Bug Fix: - Fixed the issue where the built-in Termix alert system does not display - Fixed credentials getting reset if you reset your password

gemini-code-assist[bot] commented

2025-10-09 04:41:14 +00:00

(Migrated from github.com)

Summary of Changes

Hello @LukeGus, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, labeled v1.7.3, introduces German language support, updates the terminal font, and significantly improves the password reset functionality to prevent data loss. It also includes several minor fixes, dependency updates, and UI enhancements.

Highlights

Internationalization: Added full German language support, including a new translation file and updates to language selection UI.
Password Reset Enhancement: Implemented a new password reset flow that attempts to preserve encrypted user data (SSH keys, credentials) if the user has an active session, preventing data loss that occurred in previous versions. If no active session, it logs a warning about data inaccessibility.
Terminal Experience: Replaced the default terminal font from 'JetBrains Mono Nerd Font' to 'Caskaydia Cove Nerd Font Mono' and updated font loading mechanisms.
Database Schema & Encryption: Renamed several SSH credential-related fields in the database schema (e.g., 'keyPassword' to 'key_password') and expanded the lazy field encryption mechanism to cover more sensitive user data fields (e.g., 'password_hash', 'totp_secret').
UI Persistence: Made the open/closed state of the top navbar and left sidebar persistent across sessions by storing it in 'localStorage'.
File Manager Improvements: Enhanced file manager delete operations with more specific confirmation prompts based on the number and type of items being deleted, clearly stating the permanent nature of the action.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩︎

## Summary of Changes Hello @LukeGus, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, labeled `v1.7.3`, introduces German language support, updates the terminal font, and significantly improves the password reset functionality to prevent data loss. It also includes several minor fixes, dependency updates, and UI enhancements. ### Highlights * **Internationalization**: Added full German language support, including a new translation file and updates to language selection UI. * **Password Reset Enhancement**: Implemented a new password reset flow that attempts to preserve encrypted user data (SSH keys, credentials) if the user has an active session, preventing data loss that occurred in previous versions. If no active session, it logs a warning about data inaccessibility. * **Terminal Experience**: Replaced the default terminal font from 'JetBrains Mono Nerd Font' to 'Caskaydia Cove Nerd Font Mono' and updated font loading mechanisms. * **Database Schema & Encryption**: Renamed several SSH credential-related fields in the database schema (e.g., 'keyPassword' to 'key_password') and expanded the lazy field encryption mechanism to cover more sensitive user data fields (e.g., 'password_hash', 'totp_secret'). * **UI Persistence**: Made the open/closed state of the top navbar and left sidebar persistent across sessions by storing it in 'localStorage'. * **File Manager Improvements**: Enhanced file manager delete operations with more specific confirmation prompts based on the number and type of items being deleted, clearly stating the permanent nature of the action. <details> <summary>Using Gemini Code Assist</summary> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist). </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).

gemini-code-assist[bot] (Migrated from github.com) reviewed 2025-10-09 04:43:29 +00:00

gemini-code-assist[bot] (Migrated from github.com) left a comment

Code Review

This pull request introduces several significant improvements, including the addition of German language support, a fix for a critical password reset issue that preserves user data, and an update to the terminal font for better readability. The code quality is generally high, with thoughtful refactoring in the authentication and encryption logic. I've identified a couple of areas for improvement to enhance maintainability and prevent potential bugs. Overall, this is a solid update.

## Code Review This pull request introduces several significant improvements, including the addition of German language support, a fix for a critical password reset issue that preserves user data, and an update to the terminal font for better readability. The code quality is generally high, with thoughtful refactoring in the authentication and encryption logic. I've identified a couple of areas for improvement to enhance maintainability and prevent potential bugs. Overall, this is a solid update.

src/backend/database/routes/users.ts

gemini-code-assist[bot] (Migrated from github.com) commented

2025-10-09 04:43:29 +00:00

This empty catch block swallows potential errors. While the logic might handle this, it's better to restore the original comment explaining why the error is ignored, or add logging for debugging purposes. This improves code clarity and maintainability.

    } catch (setupError) {
      // Continue if setup fails - authenticateUser will handle it
    }

![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) This empty `catch` block swallows potential errors. While the logic might handle this, it's better to restore the original comment explaining why the error is ignored, or add logging for debugging purposes. This improves code clarity and maintainability. ```typescript } catch (setupError) { // Continue if setup fails - authenticateUser will handle it } ```

src/ui/Desktop/Navigation/LeftSidebar.tsx

gemini-code-assist[bot] (Migrated from github.com) commented

2025-10-09 04:43:29 +00:00

The check for credentialId changes has been removed from the host comparison logic. This could lead to a bug where the UI does not update when a host's associated credential is changed, causing stale data to be displayed. Was the removal of this line intentional? If so, could you please clarify the reasoning? Otherwise, it should be restored to ensure UI consistency.

![high](https://www.gstatic.com/codereviewagent/high-priority.svg) The check for `credentialId` changes has been removed from the host comparison logic. This could lead to a bug where the UI does not update when a host's associated credential is changed, causing stale data to be displayed. Was the removal of this line intentional? If so, could you please clarify the reasoning? Otherwise, it should be restored to ensure UI consistency.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dennii/Termix#390