dennii/Termix
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 22 Wiki Activity

Fix RBAC role system bugs and improve UX #446

Merged
ZacharyZcR merged 7 commits from fix/rbac-improvements into dev-1.10.0 2025-12-20 02:13:36 +00:00
Conversation 0 Commits 7 Files Changed 20 +4389 -266
ZacharyZcR commented 2025-12-13 10:23:23 +00:00 (Migrated from github.com)
Copy Link

Summary

This PR fixes multiple bugs in the RBAC role system and improves user experience.

Changes

  • Fix user list dropdown selection issue in host sharing tab
  • Fix role-based host access permissions to properly query user roles
  • Fix translation template interpolation for success messages
  • Standardize system roles to only admin and user (remove obsolete roles)
  • Auto-assign user role to new registrations
  • Remove blocking confirmation dialogs in modal contexts
  • Add missing i18n translation keys
  • Fix button types to prevent unintended form submissions

Testing

  • Tested user dropdown selection in host sharing
  • Verified role-based permissions work correctly
  • Confirmed new users get auto-assigned user role
  • Validated translation interpolation displays correctly
## Summary This PR fixes multiple bugs in the RBAC role system and improves user experience. ## Changes - Fix user list dropdown selection issue in host sharing tab - Fix role-based host access permissions to properly query user roles - Fix translation template interpolation for success messages - Standardize system roles to only admin and user (remove obsolete roles) - Auto-assign user role to new registrations - Remove blocking confirmation dialogs in modal contexts - Add missing i18n translation keys - Fix button types to prevent unintended form submissions ## Testing - Tested user dropdown selection in host sharing - Verified role-based permissions work correctly - Confirmed new users get auto-assigned user role - Validated translation interpolation displays correctly
👍 2
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 security
Questions about network security
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dennii
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dennii/Termix#446
Delete Branch "fix/rbac-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?