dennii/Termix
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 22 Wiki Activity

add Dependabot and update Node version in Dockerfile #68

Merged
Lokowitz merged 5 commits from dependabot into dev-1.2 2025-08-12 18:20:15 +00:00
Conversation 2 Commits 5 Files Changed 3 +286 -1959
Lokowitz commented 2025-08-12 10:13:49 +00:00 (Migrated from github.com)
Copy Link

Hi, i like your project.
Saw that you are targeting Node 22 in your tsconfig.node.json but uses Node 18 in your Dockerfile.
This causes some warnings in building the docker image.
I also added Dependabot for continuous checks for updating the npm / dockerfile / githubaction versions.
Is the PR against main ok? Because you dont have a general dev branch.

To activate Dependabot you have to enable it in the Settings.
2025-08-12_12-16

Hi, i like your project. Saw that you are targeting Node 22 in your `tsconfig.node.json` but uses Node 18 in your Dockerfile. This causes some warnings in building the docker image. I also added Dependabot for continuous checks for updating the npm / dockerfile / githubaction versions. Is the PR against `main` ok? Because you dont have a general dev branch. To activate Dependabot you have to enable it in the Settings. <img width="1173" height="1016" alt="2025-08-12_12-16" src="https://github.com/user-attachments/assets/4b8aea46-91b2-443a-937a-79b1875b7f62" />
LukeGus commented 2025-08-12 18:18:49 +00:00 (Migrated from github.com)
Copy Link

Thank you for putting in the effort for this PR. You can make PR from main that is fine in the future, I went ahead and changed it to the latest dev branch. Good catch for finding the tsconfig.node.json, and I have always considered adding Dependabot, just haven't got around to it yet, so thank you for doing it for me! I'll look at your commits and should have this merged soon.

Thank you for putting in the effort for this PR. You can make PR from main that is fine in the future, I went ahead and changed it to the latest dev branch. Good catch for finding the `tsconfig.node.json`, and I have always considered adding Dependabot, just haven't got around to it yet, so thank you for doing it for me! I'll look at your commits and should have this merged soon.
Lokowitz commented 2025-08-21 08:10:46 +00:00 (Migrated from github.com)
Copy Link

Hey @LukeGus
i think you need to activate dependabot in your project settings to work 🙂

Hey @LukeGus i think you need to activate dependabot in your project settings to work 🙂
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 security
Questions about network security
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dennii
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dennii/Termix#68
Delete Branch "dependabot"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?