dennii/Termix
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 22 Wiki Activity

v1.7.0 #318

Merged
LukeGus merged 138 commits from dev-1.7.0 into main 2025-10-01 20:40:10 +00:00
Conversation 3 Commits 138 Files Changed 115 +6 -4
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 32921f9b7f - Show all commits

10
docker/Dockerfile
View File

@@ -11,8 +11,9 @@ ENV npm_config_target_arch=x64
ENV npm_config_target_libc=musl
RUN npm ci --force --ignore-scripts && \
npm install @rollup/rollup-linux-x64-musl @esbuild/linux-x64 --force && \
npm rebuild --build-from-source && \
if [ "$(uname -m)" = "x86_64" ]; then \
npm install @rollup/rollup-linux-x64-musl @esbuild/linux-x64 --force; \
fi && \
npm cache clean --force
# Stage 2: Build frontend
gemini-code-assist[bot] commented 2025-10-01 20:38:40 +00:00 (Migrated from github.com)
Review
Copy Link

high

This command removes package-lock.json and uses npm install --force, which undermines the principle of reproducible builds. Using npm ci is strongly recommended for Docker builds as it installs dependencies exactly as specified in package-lock.json, ensuring that the build is consistent and deterministic across all environments. If there are dependency conflicts, they should be resolved in package.json rather than being bypassed with --force.

RUN npm ci --ignore-scripts && \
    npm cache clean --force
![high](https://www.gstatic.com/codereviewagent/high-priority.svg) This command removes `package-lock.json` and uses `npm install --force`, which undermines the principle of reproducible builds. Using `npm ci` is strongly recommended for Docker builds as it installs dependencies exactly as specified in `package-lock.json`, ensuring that the build is consistent and deterministic across all environments. If there are dependency conflicts, they should be resolved in `package.json` rather than being bypassed with `--force`. ``` RUN npm ci --ignore-scripts && \ npm cache clean --force ```
@@ -21,8 +22,9 @@ WORKDIR /app
COPY . .
RUN npm install @rollup/rollup-linux-x64-musl @esbuild/linux-x64 --force && \
npm rebuild --build-from-source && \
RUN if [ "$(uname -m)" = "x86_64" ]; then \
npm install @rollup/rollup-linux-x64-musl @esbuild/linux-x64 --force; \
fi && \
npm cache clean --force && \
npm run build