Feature engineering improvements #376

Merged
LukeGus merged 20 commits from feature-engineering-improvements into dev-1.8.0 2025-10-08 01:06:01 +00:00
Showing only changes of commit 78ae23f680 - Show all commits
+8 -13
View File
@@ -607,7 +607,6 @@ async function connectSSHTunnel(
credentialId: tunnelConfig.endpointCredentialId, credentialId: tunnelConfig.endpointCredentialId,
}); });
} }
} else {
} }
} catch (error) { } catch (error) {
tunnelLogger.warn( tunnelLogger.warn(
@@ -829,12 +828,12 @@ async function connectSSHTunnel(
}); });
stream.stdout?.on("data", (data: Buffer) => { stream.stdout?.on("data", (data: Buffer) => {
const output = data.toString().trim(); // Silently consume stdout data
if (output) {
}
}); });
stream.on("error", (err: Error) => {}); stream.on("error", () => {
// Silently consume stream errors
});
stream.stderr.on("data", (data) => { stream.stderr.on("data", (data) => {
const errorMsg = data.toString().trim(); const errorMsg = data.toString().trim();
@@ -1040,7 +1039,6 @@ async function killRemoteTunnelByMarker(
authMethod: credential.auth_type || credential.authType, authMethod: credential.auth_type || credential.authType,
}; };
} }
} else {
} }
} catch (error) { } catch (error) {
tunnelLogger.warn("Failed to resolve source credentials for cleanup", { tunnelLogger.warn("Failed to resolve source credentials for cleanup", {
@@ -1128,7 +1126,7 @@ async function killRemoteTunnelByMarker(
conn.on("ready", () => { conn.on("ready", () => {
const checkCmd = `ps aux | grep -E '(${tunnelMarker}|ssh.*-R.*${tunnelConfig.endpointPort}:localhost:${tunnelConfig.sourcePort}.*${tunnelConfig.endpointUsername}@${tunnelConfig.endpointIP}|sshpass.*ssh.*-R.*${tunnelConfig.endpointPort})' | grep -v grep`; const checkCmd = `ps aux | grep -E '(${tunnelMarker}|ssh.*-R.*${tunnelConfig.endpointPort}:localhost:${tunnelConfig.sourcePort}.*${tunnelConfig.endpointUsername}@${tunnelConfig.endpointIP}|sshpass.*ssh.*-R.*${tunnelConfig.endpointPort})' | grep -v grep`;
conn.exec(checkCmd, (err, stream) => { conn.exec(checkCmd, (_err, stream) => {
let foundProcesses = false; let foundProcesses = false;
stream.on("data", (data) => { stream.on("data", (data) => {
@@ -1156,7 +1154,7 @@ async function killRemoteTunnelByMarker(
function executeNextKillCommand() { function executeNextKillCommand() {
if (commandIndex >= killCmds.length) { if (commandIndex >= killCmds.length) {
conn.exec(checkCmd, (err, verifyStream) => { conn.exec(checkCmd, (_err, verifyStream) => {
let stillRunning = false; let stillRunning = false;
verifyStream.on("data", (data) => { verifyStream.on("data", (data) => {
@@ -1189,7 +1187,6 @@ async function killRemoteTunnelByMarker(
tunnelLogger.warn( tunnelLogger.warn(
`Kill command ${commandIndex + 1} failed for '${tunnelName}': ${err.message}`, `Kill command ${commandIndex + 1} failed for '${tunnelName}': ${err.message}`,
); );
} else {
} }
stream.on("close", () => { stream.on("close", () => {
@@ -1197,10 +1194,8 @@ async function killRemoteTunnelByMarker(
executeNextKillCommand(); executeNextKillCommand();
}); });
stream.on("data", (data) => { stream.on("data", () => {
const output = data.toString().trim(); // Silently consume stream data
if (output) {
}
}); });
stream.stderr.on("data", (data) => { stream.stderr.on("data", (data) => {