dennii/Termix
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 22 Wiki Activity

fix: Resolve database encryption atomicity issues and enhance debugging #430

Merged
ZacharyZcR merged 7 commits from fix/database-encryption-atomicity into dev-1.8.1 2025-11-06 03:21:21 +00:00
Conversation 1 Commits 7 Files Changed 5
+1 -1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 333f4ca0a7 - Show all commits
src/backend/utils/database-file-encryption.ts
+1 -1
View File
4
 @@ -576,7 +576,7 @@ class DatabaseFileEncryption {
) { ) {
result.validation.filesConsistent = true; result.validation.filesConsistent = true;
if (result.metadataFile.content.dataSize) { if (result.metadataFile.content.dataSize !== undefined) {
result.validation.expectedSize = result.metadataFile.content.dataSize; result.validation.expectedSize = result.metadataFile.content.dataSize;
result.validation.actualSize = result.dataFile.size; result.validation.actualSize = result.dataFile.size;
result.validation.sizeMismatch = result.validation.sizeMismatch =
copilot-pull-request-reviewer[bot] commented 2025-11-06 03:15:55 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

The validation checks dataSize for truthiness, but 0 is a valid file size. Use result.metadataFile.content.dataSize !== undefined instead to properly handle empty encrypted files.

        if (result.metadataFile.content.dataSize !== undefined) {
The validation checks `dataSize` for truthiness, but 0 is a valid file size. Use `result.metadataFile.content.dataSize !== undefined` instead to properly handle empty encrypted files. ```suggestion if (result.metadataFile.content.dataSize !== undefined) { ```