From 0dac1ada5f30059dfc350bd0947393dcf77e47e6 Mon Sep 17 00:00:00 2001
From: Jan Prochazka <jan.prochazka@gmail.com>
Date: Wed, 7 Apr 2021 18:27:51 +0200
Subject: [PATCH] ctx menu refactor

---
 packages/web/src/datagrid/ChangeSetGrider.ts     |  2 +-
 packages/web/src/jsontree/JSONTree.svelte        |  8 +++++---
 .../web/src/jsonview/CollectionJsonRow.svelte    | 16 ++++++----------
 .../web/src/jsonview/CollectionJsonView.svelte   | 11 ++++++-----
 packages/web/src/utility/contextMenu.ts          |  8 ++++++--
 5 files changed, 24 insertions(+), 21 deletions(-)

diff --git a/packages/web/src/datagrid/ChangeSetGrider.ts b/packages/web/src/datagrid/ChangeSetGrider.ts
index 0e674b56f..591a9d984 100644
--- a/packages/web/src/datagrid/ChangeSetGrider.ts
+++ b/packages/web/src/datagrid/ChangeSetGrider.ts
@@ -60,7 +60,7 @@ export default class ChangeSetGrider extends Grider {
     this.batchChangeSet = null;
     this.compiledMacroFunc = compileMacroFunction(macro, this._errors);
 
-    console.log('changeSet', this.changeSet);
+    // console.log('changeSet', this.changeSet);
   }
 
   get errors() {
diff --git a/packages/web/src/jsontree/JSONTree.svelte b/packages/web/src/jsontree/JSONTree.svelte
index e47b7c4d5..6e0e601a3 100644
--- a/packages/web/src/jsontree/JSONTree.svelte
+++ b/packages/web/src/jsontree/JSONTree.svelte
@@ -1,22 +1,24 @@
 <script lang="ts">
   import JSONNode from './JSONNode.svelte';
   import { setContext } from 'svelte';
-  import contextMenu from '../utility/contextMenu';
+  import contextMenu, { getContextMenu } from '../utility/contextMenu';
 
   setContext('json-tree-context-key', {});
 
   export let key = '';
+  export let menu = null;
   export let value;
   export let expanded = false;
   export let labelOverride = null;
-  export let menu;
 
   export let isDeleted;
   export let isInserted;
   export let isModified;
+
+  const parentMenu = getContextMenu();
 </script>
 
-<ul use:contextMenu={menu} class:isDeleted class:isInserted class:isModified>
+<ul use:contextMenu={[parentMenu, menu]} class:isDeleted class:isInserted class:isModified>
   <JSONNode {key} {value} isParentExpanded={true} isParentArray={false} {expanded} {labelOverride} />
 </ul>
 
diff --git a/packages/web/src/jsonview/CollectionJsonRow.svelte b/packages/web/src/jsonview/CollectionJsonRow.svelte
index 72f6d0b74..efc20e55d 100644
--- a/packages/web/src/jsonview/CollectionJsonRow.svelte
+++ b/packages/web/src/jsonview/CollectionJsonRow.svelte
@@ -20,10 +20,10 @@
   import EditJsonModal from '../modals/EditJsonModal.svelte';
   import ErrorMessageModal from '../modals/ErrorMessageModal.svelte';
   import { showModal } from '../modals/modalTools';
+  import { getContextMenu, registerMenu } from '../utility/contextMenu';
 
   export let rowIndex;
   export let grider;
-  export let commonMenu;
 
   $: rowData = grider.getRowData(rowIndex);
   $: rowStatus = grider.getRowStatus(rowIndex);
@@ -32,20 +32,16 @@
     editJsonRowDocument(grider, rowIndex);
   }
 
-  function createMenu() {
-    return [
-      ...commonMenu,
-      { text: 'Edit document', onClick: handleEditDocument },
-      { text: 'Delete document', onClick: () => grider.deleteRow(rowIndex) },
-      { text: 'Revert row changes', onClick: () => grider.revertRowChanges(rowIndex) },
-    ];
-  }
+  registerMenu([
+    { text: 'Edit document', onClick: handleEditDocument },
+    { text: 'Delete document', onClick: () => grider.deleteRow(rowIndex) },
+    { text: 'Revert row changes', onClick: () => grider.revertRowChanges(rowIndex) },
+  ]);
 </script>
 
 <JSONTree
   value={rowData}
   labelOverride="({rowIndex + 1}) "
-  menu={createMenu}
   isModified={rowStatus.status == 'updated'}
   isInserted={rowStatus.status == 'inserted'}
   isDeleted={rowStatus.status == 'deleted'}
diff --git a/packages/web/src/jsonview/CollectionJsonView.svelte b/packages/web/src/jsonview/CollectionJsonView.svelte
index 674c6e93c..f4510bbfa 100644
--- a/packages/web/src/jsonview/CollectionJsonView.svelte
+++ b/packages/web/src/jsonview/CollectionJsonView.svelte
@@ -27,7 +27,7 @@
   import Pager from '../elements/Pager.svelte';
 
   import { getActiveTabId } from '../stores';
-  import contextMenu from '../utility/contextMenu';
+  import contextMenu, { getContextMenu, registerMenu } from '../utility/contextMenu';
   import CollectionJsonRow from './CollectionJsonRow.svelte';
 
   export let conid;
@@ -81,20 +81,21 @@
     invalidateCommands();
   });
 
-  const commonMenu = [{ command: 'dataJson.switchToTable' }];
+  registerMenu({ command: 'dataJson.switchToTable' });
+  const menu = getContextMenu();
 
   $: grider = new ChangeSetGrider(loadedRows, changeSetState, dispatchChangeSet, display);
 
-  $: console.log('GRIDER', grider);
+  // $: console.log('GRIDER', grider);
 </script>
 
-<div class="flexcol flex1" use:contextMenu={commonMenu}>
+<div class="flexcol flex1" use:contextMenu={menu}>
   <div class="toolbar">
     <Pager bind:skip bind:limit on:load={() => display.reload()} />
   </div>
   <div class="json">
     {#each _.range(0, grider.rowCount) as rowIndex}
-      <CollectionJsonRow {grider} {rowIndex} {commonMenu} />
+      <CollectionJsonRow {grider} {rowIndex} />
     {/each}
   </div>
 </div>
diff --git a/packages/web/src/utility/contextMenu.ts b/packages/web/src/utility/contextMenu.ts
index ffbb986fa..0281da9c7 100644
--- a/packages/web/src/utility/contextMenu.ts
+++ b/packages/web/src/utility/contextMenu.ts
@@ -4,10 +4,10 @@ import { currentDropDownMenu } from '../stores';
 
 export function registerMenu(items) {
   const parentMenu = getContext('componentContextMenu');
-  setContext('componentContextMenu', parentMenu ? [parentMenu, items] : items);
+  setContext('componentContextMenu', [parentMenu, items]);
 }
 
-export default function contextMenu(node, items) {
+export default function contextMenu(node, items = []) {
   const handleContextMenu = e => {
     e.preventDefault();
     e.stopPropagation();
@@ -47,3 +47,7 @@ export function extractMenuItems(menu) {
   doExtractMenuItems(menu, res);
   return res;
 }
+
+export function getContextMenu(): any {
+  return getContext('componentContextMenu');
+}