redis: support readonly and database url

packages/api/src/proc/databaseConnectionProcess.js

@@ -211,6 +211,10 @@ async function handleLoadKeyInfo({ msgid, key }) {
 
 async function handleCallMethod({ msgid, method, args }) {
   return handleDriverDataCore(msgid, driver => {
+    if (storedConnection.isReadOnly) {
+      throw new Error('Connection is read only, cannot call custom methods');
+    }
+
     ensureExecuteCustomScript(driver);
     return driver.callMethod(systemConnection, method, args);
   });

packages/web/src/widgets/DbKeysTreeNode.svelte

@@ -3,13 +3,13 @@
 
   import AppObjectCore from '../appobj/AppObjectCore.svelte';
   import { plusExpandIcon } from '../icons/expandIcons';
-  import FontIcon from '../icons/FontIcon.svelte';
   import ConfirmModal from '../modals/ConfirmModal.svelte';
   import InputTextModal from '../modals/InputTextModal.svelte';
   import { showModal } from '../modals/modalTools';
   import newQuery from '../query/newQuery';
   import { activeDbKeysStore } from '../stores';
   import { apiCall } from '../utility/api';
+  import { getConnectionInfo } from '../utility/metadataLoaders';
   import openNewTab from '../utility/openNewTab';
   import { showSnackbarError } from '../utility/snackbar';
 
@@ -29,9 +29,11 @@ import { showSnackbarError } from '../utility/snackbar';
   let reloadToken = 0;
 
   // $: console.log(item.text, indentLevel);
-  function createMenu() {
+  async function createMenu() {
+    const connection = await getConnectionInfo({ conid });
     return [
-      item.key != null && {
+      item.key != null &&
+        !connection?.isReadOnly && {
           label: 'Delete key',
           onClick: () => {
             showModal(ConfirmModal, {
@@ -51,7 +53,8 @@ import { showSnackbarError } from '../utility/snackbar';
             });
           },
         },
-      item.key != null && {
+      item.key != null &&
+        !connection?.isReadOnly && {
           label: 'Rename key',
           onClick: () => {
             showModal(InputTextModal, {
@@ -73,7 +76,8 @@ import { showSnackbarError } from '../utility/snackbar';
             });
           },
         },
-      item.type == 'dir' && {
+      item.type == 'dir' &&
+        !connection?.isReadOnly && {
           label: 'Reload',
           onClick: () => {
             reloadToken += 1;

plugins/dbgate-plugin-redis/src/backend/driver.js

@@ -80,16 +80,22 @@ function splitCommandLine(str) {
 const driver = {
   ...driverBase,
   analyserClass: Analyser,
-  async connect({ server, port, password, database }) {
+  async connect({ server, port, password, database, useDatabaseUrl, databaseUrl }) {
     let db = 0;
+    let pool;
+    if (useDatabaseUrl) {
+      pool = new Redis(databaseUrl);
+    } else {
       if (_.isString(database) && database.startsWith('db')) db = parseInt(database.substring(2));
       if (_.isNumber(database)) db = database;
-    const pool = new Redis({
+      pool = new Redis({
         host: server,
         port,
         password,
         db,
       });
+    }
+
     return pool;
   },
   // @ts-ignore

plugins/dbgate-plugin-redis/src/frontend/driver.js

@@ -26,6 +26,7 @@ const driver = {
   databaseEngineTypes: ['keyvalue'],
   supportedCreateDatabase: false,
   getQuerySplitterOptions: () => redisSplitterOptions,
+  databaseUrlPlaceholder: 'e.g. redis://:authpassword@127.0.0.1:6380/4',
   supportedKeyTypes: [
     {
       name: 'string',
@@ -75,7 +76,11 @@ const driver = {
   ],
 
   showConnectionField: (field, values) => {
-    return ['server', 'port', 'password'].includes(field);
+    if (field == 'useDatabaseUrl') return true;
+    if (values.useDatabaseUrl) {
+      return ['databaseUrl', 'isReadOnly'].includes(field);
+    }
+    return ['server', 'port', 'password', 'isReadOnly'].includes(field);
   },
 };