From 1e91097bf2004386a526608e7ba080630e6eabdd Mon Sep 17 00:00:00 2001
From: Jan Prochazka <jan.prochazka@gmail.com>
Date: Thu, 1 Sep 2022 16:20:35 +0200
Subject: [PATCH] splitter doesn't recreate children on collapse

---
 .../src/elements/HorizontalSplitter.svelte    | 44 +++++++++++--------
 .../web/src/elements/VerticalSplitter.svelte  | 40 ++++++++++-------
 2 files changed, 50 insertions(+), 34 deletions(-)

diff --git a/packages/web/src/elements/HorizontalSplitter.svelte b/packages/web/src/elements/HorizontalSplitter.svelte
index 5d38eb746..e2c9ec2f5 100644
--- a/packages/web/src/elements/HorizontalSplitter.svelte
+++ b/packages/web/src/elements/HorizontalSplitter.svelte
@@ -32,28 +32,35 @@
 </script>
 
 <div class="container" bind:clientWidth>
-  {#if collapsed1}
-    <div class="child1" style={`flex:1`}>
-      <slot name="2" />
-    </div>
-  {:else if collapsed2}
-    <div class="child1" style={`flex:1`}>
+  {#if !hideFirst}
+    <div
+      class="child1"
+      style={isSplitter
+        ? collapsed1
+          ? 'display:none'
+          : collapsed2
+          ? 'flex:1'
+          : `width:${size}px; min-width:${size}px; max-width:${size}px}`
+        : `flex:1`}
+    >
       <slot name="1" />
     </div>
-  {:else}
+  {/if}
+  {#if isSplitter}
     {#if !hideFirst}
-      <div class="child1" style={isSplitter ? `width:${size}px; min-width:${size}px; max-width:${size}px}` : `flex:1`}>
-        <slot name="1" />
-      </div>
-    {/if}
-    {#if isSplitter}
-      {#if !hideFirst}
-        <div class="horizontal-split-handle" use:splitterDrag={'clientX'} on:resizeSplitter={e => (size += e.detail)} />
-      {/if}
-      <div class="child2">
-        <slot name="2" />
-      </div>
+      <div
+        class="horizontal-split-handle"
+        style={collapsed1 || collapsed2 ? 'display:none' : ''}
+        use:splitterDrag={'clientX'}
+        on:resizeSplitter={e => (size += e.detail)}
+      />
     {/if}
+    <div
+      class={collapsed1 ? 'child1' : 'child2'}
+      style={collapsed2 ? 'display:none' : collapsed1 ? 'flex:1' : 'child2'}
+    >
+      <slot name="2" />
+    </div>
   {/if}
 
   {#if allowCollapseChild1 && !collapsed2 && isSplitter}
@@ -138,6 +145,7 @@
     display: flex;
     flex-direction: column;
     justify-content: center;
+    z-index: 100;
   }
 
   .collapse:hover {
diff --git a/packages/web/src/elements/VerticalSplitter.svelte b/packages/web/src/elements/VerticalSplitter.svelte
index bc3f0186a..57c22c953 100644
--- a/packages/web/src/elements/VerticalSplitter.svelte
+++ b/packages/web/src/elements/VerticalSplitter.svelte
@@ -21,24 +21,31 @@
 </script>
 
 <div class="container" bind:clientHeight>
-  {#if collapsed1}
-    <div class="child1" style={`flex:1`}>
+  <div
+    class="child1"
+    style={isSplitter
+      ? collapsed1
+        ? 'display:none'
+        : collapsed2
+        ? 'flex:1'
+        : `height:${size}px; min-height:${size}px; max-height:${size}px}`
+      : `flex:1`}
+  >
+    <slot name="1" />
+  </div>
+  {#if isSplitter}
+    <div
+      class={'vertical-split-handle'}
+      style={collapsed1 || collapsed2 ? 'display:none' : ''}
+      use:splitterDrag={'clientY'}
+      on:resizeSplitter={e => (size += e.detail)}
+    />
+    <div
+      class={collapsed1 ? 'child1' : 'child2'}
+      style={collapsed2 ? 'display:none' : collapsed1 ? 'flex:1' : 'child2'}
+    >
       <slot name="2" />
     </div>
-  {:else if collapsed2}
-    <div class="child1" style={`flex:1`}>
-      <slot name="1" />
-    </div>
-  {:else}
-    <div class="child1" style={isSplitter ? `height:${size}px; min-height:${size}px; max-height:${size}px}` : `flex:1`}>
-      <slot name="1" />
-    </div>
-    {#if isSplitter}
-      <div class="vertical-split-handle" use:splitterDrag={'clientY'} on:resizeSplitter={e => (size += e.detail)} />
-      <div class="child2">
-        <slot name="2" />
-      </div>
-    {/if}
   {/if}
 
   {#if allowCollapseChild1 && !collapsed2 && isSplitter}
@@ -123,6 +130,7 @@
     background: var(--theme-bg-2);
     display: flex;
     justify-content: center;
+    z-index: 100;
   }
 
   .collapse:hover {