dennii/dbgate
1
0
Fork 0
mirror of https://github.com/DeNNiiInc/dbgate.git synced 2026-04-27 11:25:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(table-create): remove nullable if engine skips nullability

Browse Source
This commit is contained in:
Nybkox
2025-02-06 07:12:47 +01:00
parent fd70df0f43
commit 5fc5497a9e
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
integration-tests/__tests__/table-create.spec.js
View File

@@ -24,8 +24,10 @@ function checkTableStructure2(t1, t2) {
expect(t2).toEqual(createExpector(omitTableSpecificInfo(t1))); expect(t2).toEqual(createExpector(omitTableSpecificInfo(t1)));
} }
async function testTableCreate(conn, driver, table) { async function testTableCreate(engine, conn, driver, table) {
await runCommandOnDriver(conn, driver, dmp => dmp.put('create table ~t0 (~id int not null primary key)')); await runCommandOnDriver(conn, driver, dmp =>
dmp.put(`create table ~t0 (~id int ${engine.skipNullability ? '' : 'not null'} primary key)`)
);
const dmp = driver.createDumper(); const dmp = driver.createDumper();
const table1 = { const table1 = {
@@ -47,12 +49,12 @@ describe('Table create', () => {
test.each(engines.map(engine => [engine.label, engine]))( test.each(engines.map(engine => [engine.label, engine]))(
'Simple table - %s', 'Simple table - %s',
testWrapper(async (conn, driver, engine) => { testWrapper(async (conn, driver, engine) => {
await testTableCreate(conn, driver, { await testTableCreate(engine, conn, driver, {
columns: [ columns: [
{ {
columnName: 'col1', columnName: 'col1',
dataType: 'int', dataType: 'int',
notNull: true, ...(engine.skipNullability ? {} : { notNull: true }),
}, },
], ],
primaryKey: { primaryKey: {
@@ -65,7 +67,7 @@ describe('Table create', () => {
test.each(engines.filter(x => !x.skipIndexes).map(engine => [engine.label, engine]))( test.each(engines.filter(x => !x.skipIndexes).map(engine => [engine.label, engine]))(
'Table with index - %s', 'Table with index - %s',
testWrapper(async (conn, driver, engine) => { testWrapper(async (conn, driver, engine) => {
await testTableCreate(conn, driver, { await testTableCreate(engine, conn, driver, {
columns: [ columns: [
{ {
columnName: 'col1', columnName: 'col1',
@@ -95,7 +97,7 @@ describe('Table create', () => {
test.each(engines.filter(x => !x.skipReferences).map(engine => [engine.label, engine]))( test.each(engines.filter(x => !x.skipReferences).map(engine => [engine.label, engine]))(
'Table with foreign key - %s', 'Table with foreign key - %s',
testWrapper(async (conn, driver, engine) => { testWrapper(async (conn, driver, engine) => {
await testTableCreate(conn, driver, { await testTableCreate(engine, conn, driver, {
columns: [ columns: [
{ {
columnName: 'col1', columnName: 'col1',
@@ -125,7 +127,7 @@ describe('Table create', () => {
test.each(engines.filter(x => !x.skipUnique).map(engine => [engine.label, engine]))( test.each(engines.filter(x => !x.skipUnique).map(engine => [engine.label, engine]))(
'Table with unique - %s', 'Table with unique - %s',
testWrapper(async (conn, driver, engine) => { testWrapper(async (conn, driver, engine) => {
await testTableCreate(conn, driver, { await testTableCreate(engine, conn, driver, {
columns: [ columns: [
{ {
columnName: 'col1', columnName: 'col1',