dennii/dbgate
1
0
Fork 0
mirror of https://github.com/DeNNiiInc/dbgate.git synced 2026-04-29 13:23:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "reverted testEqualConstraints"

Browse Source 
This reverts commit 57c62fbe27.
This commit is contained in:
Jan Prochazka
2024-11-06 11:21:39 +01:00
parent 57c62fbe27
commit 89a9cc4380
2 changed files with 54 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
integration-tests/engines.js
View File

@@ -188,8 +188,8 @@ const filterLocal = [
// filter local testing // filter local testing
'-MySQL', '-MySQL',
'-MariaDB', '-MariaDB',
'PostgreSQL', '-PostgreSQL',
'-SQL Server', 'SQL Server',
'-SQLite', '-SQLite',
'-CockroachDB', '-CockroachDB',
'-ClickHouse', '-ClickHouse',

91
packages/tools/src/diffTools.ts
View File

@@ -392,49 +392,62 @@ function testEqualCheck(a: CheckInfo, b: CheckInfo, opts: DbDiffOptions) {
return true; return true;
} }
// function testEqualConstraints(a: ConstraintInfo, b: ConstraintInfo, opts: DbDiffOptions = {}) {
// if (a.constraintType != b.constraintType) {
// console.debug(`Constraint ${a.pureName}: different constraint type: ${a.constraintType}, ${b.constraintType}`);
// return false;
// }
// switch (a.constraintType) {
// case 'primaryKey':
// case 'sortingKey':
// return testEqualPrimaryKeys(a as PrimaryKeyInfo, b as PrimaryKeyInfo, opts);
// case 'foreignKey':
// return testEqualForeignKeys(a as ForeignKeyInfo, b as ForeignKeyInfo, opts);
// case 'index':
// return testEqualIndex(a as IndexInfo, b as IndexInfo, opts);
// case 'unique':
// return testEqualUnique(a as UniqueInfo, b as UniqueInfo, opts);
// case 'check':
// return testEqualCheck(a as CheckInfo, b as CheckInfo, opts);
// }
// console.debug(`Unknown constraint type: ${a.pureName}`);
// return false;
// }
function testEqualConstraints(a: ConstraintInfo, b: ConstraintInfo, opts: DbDiffOptions = {}) { function testEqualConstraints(a: ConstraintInfo, b: ConstraintInfo, opts: DbDiffOptions = {}) {
const omitList = ['pairingId']; if (a.constraintType != b.constraintType) {
if (opts.ignoreForeignKeyActions) { console.debug(`Constraint ${a.pureName}: different constraint type: ${a.constraintType}, ${b.constraintType}`);
omitList.push('updateAction'); return false;
omitList.push('deleteAction');
}
if (opts.ignoreConstraintNames) {
omitList.push('constraintName');
}
if (opts.schemaMode == 'ignore') {
omitList.push('schemaName');
omitList.push('refSchemaName');
} }
const aStringified = stableStringify(_omit(a, omitList)); switch (a.constraintType) {
const bStringified = stableStringify(_omit(b, omitList)); case 'primaryKey':
case 'sortingKey':
return testEqualPrimaryKeys(a as PrimaryKeyInfo, b as PrimaryKeyInfo, opts);
case 'foreignKey':
return testEqualForeignKeys(a as ForeignKeyInfo, b as ForeignKeyInfo, opts);
case 'index':
return testEqualIndex(a as IndexInfo, b as IndexInfo, opts);
case 'unique':
return testEqualUnique(a as UniqueInfo, b as UniqueInfo, opts);
case 'check':
return testEqualCheck(a as CheckInfo, b as CheckInfo, opts);
}
return aStringified == bStringified; console.debug(`Unknown constraint type: ${a.pureName}`);
return false;
// const omitList = ['pairingId'];
// if (opts.ignoreForeignKeyActions) {
// omitList.push('updateAction');
// omitList.push('deleteAction');
// }
// if (opts.ignoreConstraintNames) {
// omitList.push('constraintName');
// }
// if (opts.schemaMode == 'ignore') {
// omitList.push('schemaName');
// omitList.push('refSchemaName');
// }
// if (a.constraintType == 'primaryKey' && b.constraintType == 'primaryKey') {
// console.log('PK1', stableStringify(_.omit(a, omitList)));
// console.log('PK2', stableStringify(_.omit(b, omitList)));
// }
// if (a.constraintType == 'foreignKey' && b.constraintType == 'foreignKey') {
// console.log('FK1', stableStringify(_omit(a, omitList)));
// console.log('FK2', stableStringify(_omit(b, omitList)));
// }
// if (a.constraintType == 'index' && b.constraintType == 'index') {
// console.log('IX1', stableStringify(_omit(a, omitList)));
// console.log('IX2', stableStringify(_omit(b, omitList)));
// }
// const aStringified = stableStringify(_omit(a, omitList));
// const bStringified = stableStringify(_omit(b, omitList));
// return aStringified == bStringified;
} }
export function testEqualTypes(a: ColumnInfo, b: ColumnInfo, opts: DbDiffOptions = {}) { export function testEqualTypes(a: ColumnInfo, b: ColumnInfo, opts: DbDiffOptions = {}) {