respect readonly connection flag in table editor

This commit is contained in:
Jan Prochazka
2024-08-27 11:13:10 +02:00
parent 93f64a6bab
commit b9737533bd
7 changed files with 58 additions and 16 deletions

View File

@@ -8,9 +8,12 @@
export let icon = 'icon chevron-down'; export let icon = 'icon chevron-down';
export let menu; export let menu;
export let narrow = false; export let narrow = false;
export let disabled = false;
let domButton; let domButton;
function handleClick() { function handleClick() {
if (disabled) return;
const rect = domButton.getBoundingClientRect(); const rect = domButton.getBoundingClientRect();
const left = rect.left; const left = rect.left;
const top = rect.bottom; const top = rect.bottom;
@@ -18,6 +21,6 @@
} }
</script> </script>
<InlineButton square {narrow} on:click={handleClick} bind:this={domButton}> <InlineButton square {narrow} on:click={handleClick} bind:this={domButton} {disabled}>
<FontIcon {icon} /> <FontIcon {icon} />
</InlineButton> </InlineButton>

View File

@@ -22,6 +22,7 @@
<div class="flex"> <div class="flex">
<TextField <TextField
{...$$restProps} {...$$restProps}
{disabled}
value={$values[name] ?? defaultValue} value={$values[name] ?? defaultValue}
on:input={e => setFieldValue(name, e.target['value'])} on:input={e => setFieldValue(name, e.target['value'])}
/> />

View File

@@ -19,6 +19,8 @@
export let driver = null; export let driver = null;
export let addDataCommand = false; export let addDataCommand = false;
$: isReadOnly = !setTableInfo;
</script> </script>
<FormProvider initialValues={fillEditorColumnInfo(columnInfo || {}, tableInfo)}> <FormProvider initialValues={fillEditorColumnInfo(columnInfo || {}, tableInfo)}>
@@ -27,33 +29,35 @@
>{columnInfo ? 'Edit column' : `Add column ${(tableInfo?.columns || []).length + 1}`}</svelte:fragment >{columnInfo ? 'Edit column' : `Add column ${(tableInfo?.columns || []).length + 1}`}</svelte:fragment
> >
<FormTextField name="columnName" label="Column name" focused /> <FormTextField name="columnName" label="Column name" focused disabled={isReadOnly} />
<DataTypeEditor dialect={driver?.dialect} /> <DataTypeEditor dialect={driver?.dialect} disabled={isReadOnly} />
<FormCheckboxField name="notNull" label="NOT NULL" /> <FormCheckboxField name="notNull" label="NOT NULL" disabled={isReadOnly} />
<FormCheckboxField name="isPrimaryKey" label="Is Primary Key" /> <FormCheckboxField name="isPrimaryKey" label="Is Primary Key" disabled={isReadOnly} />
<FormCheckboxField name="autoIncrement" label="Is Autoincrement" /> <FormCheckboxField name="autoIncrement" label="Is Autoincrement" disabled={isReadOnly} />
<FormTextField <FormTextField
name="defaultValue" name="defaultValue"
label="Default value. Please use valid SQL expression, eg. 'Hello World' for string value, '' for empty string" label="Default value. Please use valid SQL expression, eg. 'Hello World' for string value, '' for empty string"
disabled={!setTableInfo}
/> />
<FormTextField name="computedExpression" label="Computed expression" /> <FormTextField name="computedExpression" label="Computed expression" disabled={isReadOnly} />
{#if driver?.dialect?.columnProperties?.isUnsigned} {#if driver?.dialect?.columnProperties?.isUnsigned}
<FormCheckboxField name="isUnsigned" label="Unsigned" /> <FormCheckboxField name="isUnsigned" label="Unsigned" disabled={isReadOnly} />
{/if} {/if}
{#if driver?.dialect?.columnProperties?.isZerofill} {#if driver?.dialect?.columnProperties?.isZerofill}
<FormCheckboxField name="isZerofill" label="Zero fill" /> <FormCheckboxField name="isZerofill" label="Zero fill" disabled={isReadOnly} />
{/if} {/if}
{#if driver?.dialect?.columnProperties?.columnComment} {#if driver?.dialect?.columnProperties?.columnComment}
<FormTextField name="columnComment" label="Comment" /> <FormTextField name="columnComment" label="Comment" disabled={isReadOnly} />
{/if} {/if}
{#if driver?.dialect?.columnProperties?.isSparse} {#if driver?.dialect?.columnProperties?.isSparse}
<FormCheckboxField name="isSparse" label="Sparse" /> <FormCheckboxField name="isSparse" label="Sparse" disabled={isReadOnly} />
{/if} {/if}
<svelte:fragment slot="footer"> <svelte:fragment slot="footer">
<FormSubmit <FormSubmit
value={columnInfo ? 'Save' : 'Save and next'} value={columnInfo ? 'Save' : 'Save and next'}
disabled={isReadOnly}
on:click={e => { on:click={e => {
closeCurrentModal(); closeCurrentModal();
if (columnInfo) { if (columnInfo) {
@@ -68,6 +72,7 @@
<FormButton <FormButton
type="button" type="button"
value="Save" value="Save"
disabled={isReadOnly}
on:click={e => { on:click={e => {
closeCurrentModal(); closeCurrentModal();
setTableInfo(tbl => editorAddColumn(tbl, e.detail, addDataCommand)); setTableInfo(tbl => editorAddColumn(tbl, e.detail, addDataCommand));

View File

@@ -33,6 +33,8 @@
...(getExtractConstraintProps ? getExtractConstraintProps() : {}), ...(getExtractConstraintProps ? getExtractConstraintProps() : {}),
}; };
} }
$: isReadOnly = !setTableInfo;
</script> </script>
<FormProvider> <FormProvider>
@@ -45,7 +47,12 @@
<div class="row"> <div class="row">
<div class="label col-3">{constraintNameLabel}</div> <div class="label col-3">{constraintNameLabel}</div>
<div class="col-9"> <div class="col-9">
<TextField value={constraintName} on:input={e => (constraintName = e.target['value'])} focused /> <TextField
value={constraintName}
on:input={e => (constraintName = e.target['value'])}
focused
disabled={isReadOnly}
/>
</div> </div>
</div> </div>
@@ -61,6 +68,7 @@
<SelectField <SelectField
value={column.columnName} value={column.columnName}
isNative isNative
disabled={isReadOnly}
options={tableInfo.columns.map(col => ({ options={tableInfo.columns.map(col => ({
label: col.columnName, label: col.columnName,
value: col.columnName, value: col.columnName,
@@ -81,6 +89,7 @@
<div class="col-3 button"> <div class="col-3 button">
<FormStyledButton <FormStyledButton
value="Delete" value="Delete"
disabled={isReadOnly}
on:click={e => { on:click={e => {
const x = [...columns]; const x = [...columns];
x.splice(index, 1); x.splice(index, 1);
@@ -97,6 +106,7 @@
{#key columns.length} {#key columns.length}
<SelectField <SelectField
placeholder="Select column" placeholder="Select column"
disabled={isReadOnly}
value={''} value={''}
on:change={e => { on:change={e => {
if (e.detail) if (e.detail)
@@ -127,6 +137,7 @@
<svelte:fragment slot="footer"> <svelte:fragment slot="footer">
<FormSubmit <FormSubmit
value={'Save'} value={'Save'}
disabled={isReadOnly}
on:click={() => { on:click={() => {
closeCurrentModal(); closeCurrentModal();
if (constraintInfo) { if (constraintInfo) {
@@ -142,6 +153,7 @@
<FormStyledButton <FormStyledButton
type="button" type="button"
value="Remove" value="Remove"
disabled={isReadOnly}
on:click={() => { on:click={() => {
closeCurrentModal(); closeCurrentModal();
setTableInfo(tbl => editorDeleteConstraint(tbl, constraintInfo)); setTableInfo(tbl => editorDeleteConstraint(tbl, constraintInfo));

View File

@@ -14,6 +14,7 @@
} }
export let dialect; export let dialect;
export let disabled = false;
</script> </script>
<FormDropDownTextField name="dataType" label="Data type" menu={createDataTypesMenu} /> <FormDropDownTextField name="dataType" label="Data type" menu={createDataTypesMenu} {disabled} />

View File

@@ -53,6 +53,8 @@
updateAction: _.startCase(updateAction).toUpperCase(), updateAction: _.startCase(updateAction).toUpperCase(),
}; };
} }
$: isReadOnly = !setTableInfo;
</script> </script>
<FormProvider> <FormProvider>
@@ -63,7 +65,12 @@
<div class="row"> <div class="row">
<div class="label col-3">Constraint name</div> <div class="label col-3">Constraint name</div>
<div class="col-9"> <div class="col-9">
<TextField value={constraintName} on:input={e => (constraintName = e.target['value'])} focused /> <TextField
value={constraintName}
on:input={e => (constraintName = e.target['value'])}
focused
disabled={isReadOnly}
/>
</div> </div>
</div> </div>
@@ -78,6 +85,7 @@
label: fullNameToLabel(tbl), label: fullNameToLabel(tbl),
value: fullNameToString(tbl), value: fullNameToString(tbl),
}))} }))}
disabled={isReadOnly}
on:change={e => { on:change={e => {
if (e.detail) { if (e.detail) {
const name = fullNameFromString(e.detail); const name = fullNameFromString(e.detail);
@@ -97,6 +105,7 @@
isNative isNative
notSelected notSelected
options={foreignKeyActionsOptions} options={foreignKeyActionsOptions}
disabled={isReadOnly}
on:change={e => { on:change={e => {
updateAction = e.detail || null; updateAction = e.detail || null;
}} }}
@@ -112,6 +121,7 @@
isNative isNative
notSelected notSelected
options={foreignKeyActionsOptions} options={foreignKeyActionsOptions}
disabled={isReadOnly}
on:change={e => { on:change={e => {
deleteAction = e.detail || null; deleteAction = e.detail || null;
}} }}
@@ -136,6 +146,7 @@
value={column.columnName} value={column.columnName}
isNative isNative
notSelected notSelected
disabled={isReadOnly}
options={tableInfo.columns.map(col => ({ options={tableInfo.columns.map(col => ({
label: col.columnName, label: col.columnName,
value: col.columnName, value: col.columnName,
@@ -154,6 +165,7 @@
value={column.refColumnName} value={column.refColumnName}
isNative isNative
notSelected notSelected
disabled={isReadOnly}
options={(refTableInfo?.columns || []).map(col => ({ options={(refTableInfo?.columns || []).map(col => ({
label: col.columnName, label: col.columnName,
value: col.columnName, value: col.columnName,
@@ -169,6 +181,7 @@
<div class="col-2 button"> <div class="col-2 button">
<FormStyledButton <FormStyledButton
value="Delete" value="Delete"
disabled={isReadOnly}
on:click={e => { on:click={e => {
const x = [...columns]; const x = [...columns];
x.splice(index, 1); x.splice(index, 1);
@@ -182,6 +195,7 @@
<FormStyledButton <FormStyledButton
type="button" type="button"
value="Add column" value="Add column"
disabled={isReadOnly}
on:click={() => { on:click={() => {
columns = [...columns, {}]; columns = [...columns, {}];
}} }}
@@ -190,7 +204,8 @@
<svelte:fragment slot="footer"> <svelte:fragment slot="footer">
<FormSubmit <FormSubmit
value={'Save'} value="Save"
disabled={isReadOnly}
on:click={() => { on:click={() => {
closeCurrentModal(); closeCurrentModal();
if (constraintInfo) { if (constraintInfo) {
@@ -205,6 +220,7 @@
{#if constraintInfo} {#if constraintInfo}
<FormStyledButton <FormStyledButton
type="button" type="button"
disabled={isReadOnly}
value="Remove" value="Remove"
on:click={() => { on:click={() => {
closeCurrentModal(); closeCurrentModal();

View File

@@ -16,6 +16,8 @@
isUnique, isUnique,
}; };
} }
$: isReadOnly = !setTableInfo;
</script> </script>
<ColumnsConstraintEditorModal <ColumnsConstraintEditorModal
@@ -32,6 +34,7 @@
<SelectField <SelectField
value={column.isDescending ? 'desc' : 'asc'} value={column.isDescending ? 'desc' : 'asc'}
isNative isNative
disabled={isReadOnly}
options={[ options={[
{ label: 'ASC', value: 'asc' }, { label: 'ASC', value: 'asc' },
{ label: 'DESC', value: 'desc' }, { label: 'DESC', value: 'desc' },
@@ -53,7 +56,8 @@
<svelte:fragment slot="constraintProps"> <svelte:fragment slot="constraintProps">
<div class="largeFormMarker"> <div class="largeFormMarker">
<div class="row"> <div class="row">
<CheckboxField checked={isUnique} on:change={e => (isUnique = e.target.checked)} /> Is unique index <CheckboxField checked={isUnique} on:change={e => (isUnique = e.target.checked)} disabled={isReadOnly} /> Is unique
index
</div> </div>
</div> </div>
</svelte:fragment> </svelte:fragment>