From b99e3ed17755cb2821578d71e1b4783bb0a42159 Mon Sep 17 00:00:00 2001
From: Jan Prochazka <jan.prochazka@gmail.com>
Date: Thu, 24 Jun 2021 09:22:12 +0200
Subject: [PATCH] #136 configurable thousands separator in grid

---
 packages/web/src/datagrid/DataGrid.svelte     |  2 --
 packages/web/src/datagrid/DataGridCell.svelte | 25 ++++++++++++-------
 .../web/src/settings/SettingsModal.svelte     |  2 ++
 3 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/packages/web/src/datagrid/DataGrid.svelte b/packages/web/src/datagrid/DataGrid.svelte
index d0a7f2b80..6db0cd8cc 100644
--- a/packages/web/src/datagrid/DataGrid.svelte
+++ b/packages/web/src/datagrid/DataGrid.svelte
@@ -66,8 +66,6 @@
   import _ from 'lodash';
   import registerCommand from '../commands/registerCommand';
   import { registerMenu } from '../utility/contextMenu';
-  import { useSettings } from '../utility/metadataLoaders';
-  import { getCurrentSettings } from '../stores';
   import { getBoolSettingsValue } from '../settings/settingsTools';
 
   export let config;
diff --git a/packages/web/src/datagrid/DataGridCell.svelte b/packages/web/src/datagrid/DataGridCell.svelte
index af71983ba..454dfa4ef 100644
--- a/packages/web/src/datagrid/DataGridCell.svelte
+++ b/packages/web/src/datagrid/DataGridCell.svelte
@@ -13,6 +13,18 @@
   }
 
   const dateTimeRegex = /^\d\d\d\d-\d\d-\d\dT\d\d:\d\d:\d\d(\.\d\d\d)?Z?$/;
+
+  function formatNumber(value) {
+    if (value >= 10000 || value <= -10000) {
+      if (getBoolSettingsValue('dataGrid.thousandsSeparator', false)) {
+        return value.toLocaleString();
+      } else {
+        return value.toString();
+      }
+    }
+
+    return value.toString();
+  }
 </script>
 
 <script lang="ts">
@@ -20,6 +32,7 @@
   import _ from 'lodash';
   import { isTypeLogical } from 'dbgate-tools';
   import ShowFormButton from '../formview/ShowFormButton.svelte';
+  import { getBoolSettingsValue } from '../settings/settingsTools';
 
   export let rowIndex;
   export let col;
@@ -80,16 +93,10 @@
         0
       {/if}
     {:else if _.isNumber(value)}
-      {#if value >= 10000 || value <= -10000}
-        {#if isDynamicStructure}
-          <span class="value">{value.toLocaleString()}</span>
-        {:else}
-          {value.toLocaleString()}
-        {/if}
-      {:else if isDynamicStructure}
-        <span class="value">{value.toString()}</span>
+      {#if isDynamicStructure}
+        <span class="value">{formatNumber(value)}</span>
       {:else}
-        {value.toString()}
+        {formatNumber(value)}
       {/if}
     {:else if _.isString(value)}
       {#if dateTimeRegex.test(value)}
diff --git a/packages/web/src/settings/SettingsModal.svelte b/packages/web/src/settings/SettingsModal.svelte
index fec407219..774c379f7 100644
--- a/packages/web/src/settings/SettingsModal.svelte
+++ b/packages/web/src/settings/SettingsModal.svelte
@@ -46,6 +46,8 @@
       />
       <FormCheckboxField name="dataGrid.showHintColumns" label="Show foreign key hints" defaultValue={true} />
 
+      <FormCheckboxField name="dataGrid.thousandsSeparator" label="Use thounds separator for numbers" />
+
       <div class="heading">Connection</div>
       <FormCheckboxField
         name="connection.autoRefresh"