diff --git a/packages/tools/src/diffTools.ts b/packages/tools/src/diffTools.ts index f3b7fb33d..ecda30151 100644 --- a/packages/tools/src/diffTools.ts +++ b/packages/tools/src/diffTools.ts @@ -507,9 +507,7 @@ export function getAlterTableScript( const plan = createAlterTablePlan(oldTable, newTable, opts, wholeOldDb, wholeNewDb, driver); const dmp = driver.createDumper({ useHardSeparator: true }); - if (!driver.dialect.disableExplicitTransaction) dmp.beginTransaction(); plan.run(dmp); - if (!driver.dialect.disableExplicitTransaction) dmp.commitTransaction(); return { sql: dmp.s, recreates: plan.recreates, @@ -526,9 +524,7 @@ export function getAlterDatabaseScript( ) { const plan = createAlterDatabasePlan(oldDb, newDb, opts, wholeOldDb, wholeNewDb, driver); const dmp = driver.createDumper({ useHardSeparator: true }); - if (!driver.dialect.disableExplicitTransaction) dmp.beginTransaction(); plan.run(dmp); - if (!driver.dialect.disableExplicitTransaction) dmp.commitTransaction(); return { sql: dmp.s, recreates: plan.recreates, diff --git a/packages/types/dialect.d.ts b/packages/types/dialect.d.ts index a8a1b2378..8669b4f6a 100644 --- a/packages/types/dialect.d.ts +++ b/packages/types/dialect.d.ts @@ -32,7 +32,6 @@ export interface SqlDialect { dropCheck?: boolean; dropReferencesWhenDropTable?: boolean; - disableExplicitTransaction?: boolean; predefinedDataTypes: string[]; diff --git a/packages/web/src/tabs/CompareModelTab.svelte b/packages/web/src/tabs/CompareModelTab.svelte index 4bec9a75f..ebff38421 100644 --- a/packages/web/src/tabs/CompareModelTab.svelte +++ b/packages/web/src/tabs/CompareModelTab.svelte @@ -277,7 +277,7 @@ const conid = $values?.targetConid; const database = $values?.targetDatabase; - const resp = await apiCall('database-connections/run-script', { conid, database, sql }); + const resp = await apiCall('database-connections/run-script', { conid, database, sql, useTransaction: true }); const { errorMessage } = resp || {}; if (errorMessage) { showModal(ErrorMessageModal, { title: 'Error when saving', message: errorMessage }); diff --git a/packages/web/src/tabs/TableStructureTab.svelte b/packages/web/src/tabs/TableStructureTab.svelte index f4f59bc19..5dbe2db2b 100644 --- a/packages/web/src/tabs/TableStructureTab.svelte +++ b/packages/web/src/tabs/TableStructureTab.svelte @@ -131,7 +131,7 @@ } async function handleConfirmSql(sql, createTableName) { - const resp = await apiCall('database-connections/run-script', { conid, database, sql }); + const resp = await apiCall('database-connections/run-script', { conid, database, sql, useTransaction: true }); const { errorMessage } = resp || {}; if (errorMessage) { showModal(ErrorMessageModal, { title: 'Error when saving', message: errorMessage }); diff --git a/plugins/dbgate-plugin-sqlite/src/frontend/driver.js b/plugins/dbgate-plugin-sqlite/src/frontend/driver.js index 8632d13c0..de6071d77 100644 --- a/plugins/dbgate-plugin-sqlite/src/frontend/driver.js +++ b/plugins/dbgate-plugin-sqlite/src/frontend/driver.js @@ -22,7 +22,6 @@ const dialect = { return `[${s}]`; }, anonymousPrimaryKey: true, - disableExplicitTransaction: true, createColumn: true, dropColumn: true,