fixed error logging

This commit is contained in:
Jan Prochazka
2023-01-21 18:00:59 +01:00
parent cc0f05168d
commit d4f0882054
12 changed files with 22 additions and 22 deletions

View File

@@ -8,11 +8,11 @@ function childProcessChecker() {
setInterval(() => {
try {
process.send({ msgtype: 'ping', counter: counter++ });
} catch (ex) {
} catch (err) {
// This will come once parent dies.
// One way can be to check for error code ERR_IPC_CHANNEL_CLOSED
// and call process.exit()
logger.error('parent died', ex);
logger.error({ err }, 'parent died');
process.exit(1);
}
}, 1000);

View File

@@ -131,8 +131,8 @@ function migrateDataDir() {
if (fs.existsSync(oldDir) && !fs.existsSync(newDir)) {
fs.renameSync(oldDir, newDir);
}
} catch (e) {
logger.error('Error migrating data dir:', e.message);
} catch (err) {
logger.error({ err }, 'Error migrating data dir');
}
}

View File

@@ -16,7 +16,7 @@ module.exports = function useController(app, electron, route, controller) {
try {
controller._init();
} catch (err) {
logger.error(`Error initializing controller, exiting application`, err);
logger.error({ err }, `Error initializing controller, exiting application`);
process.exit(1);
}
}
@@ -77,16 +77,16 @@ module.exports = function useController(app, electron, route, controller) {
try {
const data = await controller[key]({ ...req.body, ...req.query }, req);
res.json(data);
} catch (e) {
logger.error(`Error when processing route ${route}/${key}`, e);
if (e instanceof MissingCredentialsError) {
} catch (err) {
logger.error({ err }, `Error when processing route ${route}/${key}`);
if (err instanceof MissingCredentialsError) {
res.json({
missingCredentials: true,
apiErrorMessage: 'Missing credentials',
detail: e.detail,
detail: err.detail,
});
} else {
res.status(500).json({ apiErrorMessage: e.message });
res.status(500).json({ apiErrorMessage: err.message });
}
}
});