Implement base64 encoding for binary data in SQL dumper and modify row handling in MySQL and MSSQL drivers

This commit is contained in:
Stela Augustinova
2025-11-06 12:30:48 +01:00
parent 37d54811e0
commit dca9ea24d7
4 changed files with 52 additions and 21 deletions

View File

@@ -24,6 +24,15 @@ function extractTediousColumns(columns, addDriverNativeColumn = false) {
return res;
}
function modifyRow(row, columns) {
columns.forEach((col) => {
if (Buffer.isBuffer(row[col.columnName])) {
row[col.columnName] = { $binary: { base64: Buffer.from(row[col.columnName]).toString('base64') } };
}
});
return row;
}
async function getDefaultAzureSqlToken() {
const credential = new ManagedIdentityCredential();
const tokenResponse = await credential.getToken('https://database.windows.net/.default');
@@ -121,9 +130,12 @@ async function tediousQueryCore(dbhan, sql, options) {
});
request.on('row', function (columns) {
result.rows.push(
_.zipObject(
result.columns.map(x => x.columnName),
columns.map(x => x.value)
modifyRow(
_.zipObject(
result.columns.map(x => x.columnName),
columns.map(x => x.value)
),
result.columns
)
);
});
@@ -148,13 +160,17 @@ async function tediousReadQuery(dbhan, sql, structure) {
currentColumns = extractTediousColumns(columns);
pass.write({
__isStreamHeader: true,
engine: 'mssql@dbgate-plugin-mssql',
...(structure || { columns: currentColumns }),
});
});
request.on('row', function (columns) {
const row = _.zipObject(
currentColumns.map(x => x.columnName),
columns.map(x => x.value)
const row = modifyRow(
_.zipObject(
currentColumns.map(x => x.columnName),
columns.map(x => x.value)
),
currentColumns
);
pass.write(row);
});
@@ -204,12 +220,15 @@ async function tediousStream(dbhan, sql, options) {
});
request.on('columnMetadata', function (columns) {
currentColumns = extractTediousColumns(columns);
options.recordset(currentColumns);
options.recordset(currentColumns, { engine: 'mssql@dbgate-plugin-mssql' });
});
request.on('row', function (columns) {
const row = _.zipObject(
currentColumns.map(x => x.columnName),
columns.map(x => x.value)
const row = modifyRow(
_.zipObject(
currentColumns.map(x => x.columnName),
columns.map(x => x.value)
),
currentColumns
);
options.row(row);
});

View File

@@ -21,7 +21,7 @@ function extractColumns(fields) {
return null;
}
function transformRow(row, columns) {
function modifyRow(row, columns) {
columns.forEach((col) => {
if (Buffer.isBuffer(row[col.columnName])) {
row[col.columnName] = { $binary: { base64: Buffer.from(row[col.columnName]).toString('base64') } };
@@ -106,7 +106,7 @@ const drivers = driverBases.map(driverBase => ({
dbhan.client.query(sql, function (error, results, fields) {
if (error) reject(error);
const columns = extractColumns(fields);
resolve({ rows: results && columns && results.map && results.map(row => transformRow(zipDataRow(row, columns), columns)), columns });
resolve({ rows: results && columns && results.map && results.map(row => modifyRow(zipDataRow(row, columns), columns)), columns });
});
});
},
@@ -139,7 +139,7 @@ const drivers = driverBases.map(driverBase => ({
options.recordset(columns, { engine: driverBase.engine });
} else {
if (columns) {
options.row(transformRow(zipDataRow(row, columns), columns));
options.row(modifyRow(zipDataRow(row, columns), columns));
}
}
};
@@ -184,7 +184,7 @@ const drivers = driverBases.map(driverBase => ({
...(structure || { columns }),
});
})
.on('result', row => pass.write(transformRow(zipDataRow(row, columns), columns)))
.on('result', row => pass.write(modifyRow(zipDataRow(row, columns), columns)))
.on('end', () => pass.end());
return pass;