## Summary
- Fix disk available space display (was showing total instead of available)
- Fix emoji rendering artifacts (activate Unicode 11 in XTerm)
- Include credentials in host export (was exporting incomplete data)
## Details
### Disk Space Display (#313)
- Parse `Avail` column from df output
- Display actual available space instead of total
### Emoji Rendering (#266)
- Activate Unicode 11 in XTerm terminal
- Remove latin1 fallback that breaks multi-byte UTF-8
- Fixes double-width overlap artifacts
### Host Export (#254)
- Add `/db/host/:id/export` API endpoint with decryption
- Export plaintext credentials for full portability
- Update warning messages to reflect plaintext export
## Test Plan
- [x] TypeScript compilation passes
- [x] Disk metrics show correct available space
- [x] Emoji render without artifacts in terminal
- [x] Host export includes credentials and is importable
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Hello @ZacharyZcR, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request delivers crucial fixes and enhancements across the application's UI and backend data handling. It corrects the display of available disk space in server monitoring, resolves visual glitches with emoji rendering in terminal sessions, and significantly upgrades the host export feature to include sensitive credentials, thereby improving data portability while clearly communicating security implications to the user.
Highlights
Disk Space Display Correction: The server metrics UI now accurately displays available disk space by parsing the 'Avail' column from the df command output, resolving a bug where it previously showed total disk space.
Enhanced Host Export with Credentials: A new API endpoint and corresponding UI logic have been implemented to allow exporting SSH host configurations, including decrypted sensitive credentials (passwords, SSH keys). This ensures full portability of host data, with updated warning messages to inform users about the plaintext nature of the exported sensitive information.
Improved Emoji Rendering in Terminal: Unicode 11 has been activated in both desktop and mobile XTerm terminals. This change fixes rendering artifacts and double-width issues, ensuring emojis and other multi-byte characters are displayed correctly.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Feature
Command
Description
Code Review
/gemini review
Performs a code review for the current pull request in its current state.
Pull Request Summary
/gemini summary
Provides a summary of the current pull request in its current state.
Comment
@gemini-code-assist
Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help
/gemini help
Displays a list of available commands.
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
## Summary of Changes
Hello @ZacharyZcR, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request delivers crucial fixes and enhancements across the application's UI and backend data handling. It corrects the display of available disk space in server monitoring, resolves visual glitches with emoji rendering in terminal sessions, and significantly upgrades the host export feature to include sensitive credentials, thereby improving data portability while clearly communicating security implications to the user.
### Highlights
* **Disk Space Display Correction**: The server metrics UI now accurately displays available disk space by parsing the 'Avail' column from the `df` command output, resolving a bug where it previously showed total disk space.
* **Enhanced Host Export with Credentials**: A new API endpoint and corresponding UI logic have been implemented to allow exporting SSH host configurations, including decrypted sensitive credentials (passwords, SSH keys). This ensures full portability of host data, with updated warning messages to inform users about the plaintext nature of the exported sensitive information.
* **Improved Emoji Rendering in Terminal**: Unicode 11 has been activated in both desktop and mobile XTerm terminals. This change fixes rendering artifacts and double-width issues, ensuring emojis and other multi-byte characters are displayed correctly.
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
gemini-code-assist[bot]
(Migrated from github.com)
reviewed 2025-10-02 17:08:20 +10:00
gemini-code-assist[bot]
(Migrated from github.com)
left a comment
Copy Link
Copy Source
Code Review
This pull request introduces several important fixes, including a new backend endpoint to export host configurations with sensitive credentials, which resolves an incomplete data export issue. The UI is updated to use this new endpoint and to correctly display available disk space instead of total space. Additionally, emoji rendering in the terminal is fixed by enabling Unicode 11 support. My review focuses on improving the security and robustness of the new export endpoint and some minor code cleanup in the frontend. Overall, the changes are well-implemented and address critical issues.
## Code Review
This pull request introduces several important fixes, including a new backend endpoint to export host configurations with sensitive credentials, which resolves an incomplete data export issue. The UI is updated to use this new endpoint and to correctly display available disk space instead of total space. Additionally, emoji rendering in the terminal is fixed by enabling Unicode 11 support. My review focuses on improving the security and robustness of the new export endpoint and some minor code cleanup in the frontend. Overall, the changes are well-implemented and address critical issues.
Using a GET request to export sensitive data can be a security risk. GET requests, including their paths, are often logged by servers, proxies, and in browser history. It's a best practice to use POST for actions that involve sensitive data to avoid leaking identifiers like hostId in logs.
You'll also need to update the corresponding frontend client in src/ui/main-axios.ts to use sshHostApi.post.
router.post(
Using a `GET` request to export sensitive data can be a security risk. GET requests, including their paths, are often logged by servers, proxies, and in browser history. It's a best practice to use `POST` for actions that involve sensitive data to avoid leaking identifiers like `hostId` in logs.
You'll also need to update the corresponding frontend client in `src/ui/main-axios.ts` to use `sshHostApi.post`.
```suggestion
router.post(
```
The hostId from req.params.id is used as a string and converted to a number in multiple places. This can lead to inconsistencies and potential issues if the parameter is not a valid number. It's more robust to parse and validate it once at the beginning of the handler. After this change, you can use the hostId variable directly as a number throughout the function, removing the need for Number(hostId) and parseInt(hostId).
const hostId = parseInt(req.params.id, 10);
const userId = (req as any).userId;
if (!isNonEmptyString(userId) || isNaN(hostId)) {
return res.status(400).json({ error: "Invalid userId or hostId" });
}
The `hostId` from `req.params.id` is used as a string and converted to a number in multiple places. This can lead to inconsistencies and potential issues if the parameter is not a valid number. It's more robust to parse and validate it once at the beginning of the handler. After this change, you can use the `hostId` variable directly as a number throughout the function, removing the need for `Number(hostId)` and `parseInt(hostId)`.
```suggestion
const hostId = parseInt(req.params.id, 10);
const userId = (req as any).userId;
if (!isNonEmptyString(userId) || isNaN(hostId)) {
return res.status(400).json({ error: "Invalid userId or hostId" });
}
```
The actualAuthType parameter is passed to the performExport function but is no longer used within its body. Removing it will clean up the code. You will also need to update the call sites for this function in handleExport.
const performExport = async (host: SSHHost) => {
The `actualAuthType` parameter is passed to the `performExport` function but is no longer used within its body. Removing it will clean up the code. You will also need to update the call sites for this function in `handleExport`.
```suggestion
const performExport = async (host: SSHHost) => {
```
LukeGus
(Migrated from github.com)
approved these changes 2025-10-03 07:29:00 +10:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
Details
Disk Space Display (#313)
Availcolumn from df outputEmoji Rendering (#266)
Host Export (#254)
/db/host/:id/exportAPI endpoint with decryptionTest Plan
🤖 Generated with Claude Code
Summary of Changes
Hello @ZacharyZcR, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request delivers crucial fixes and enhancements across the application's UI and backend data handling. It corrects the display of available disk space in server monitoring, resolves visual glitches with emoji rendering in terminal sessions, and significantly upgrades the host export feature to include sensitive credentials, thereby improving data portability while clearly communicating security implications to the user.
Highlights
dfcommand output, resolving a bug where it previously showed total disk space.Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either
/gemini <command>or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page./gemini review/gemini summary/gemini helpCustomization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a
.gemini/folder in the base of the repository. Detailed instructions can be found here.Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩︎
Code Review
This pull request introduces several important fixes, including a new backend endpoint to export host configurations with sensitive credentials, which resolves an incomplete data export issue. The UI is updated to use this new endpoint and to correctly display available disk space instead of total space. Additionally, emoji rendering in the terminal is fixed by enabling Unicode 11 support. My review focuses on improving the security and robustness of the new export endpoint and some minor code cleanup in the frontend. Overall, the changes are well-implemented and address critical issues.
@@ -672,1 +672,4 @@// Route: Export SSH host with decrypted credentials (requires data access)// GET /ssh/db/host/:id/exportrouter.get(Using a
GETrequest to export sensitive data can be a security risk. GET requests, including their paths, are often logged by servers, proxies, and in browser history. It's a best practice to usePOSTfor actions that involve sensitive data to avoid leaking identifiers likehostIdin logs.You'll also need to update the corresponding frontend client in
src/ui/main-axios.tsto usesshHostApi.post.@@ -673,0 +682,4 @@if (!isNonEmptyString(userId) || !hostId) {return res.status(400).json({ error: "Invalid userId or hostId" });}The
hostIdfromreq.params.idis used as a string and converted to a number in multiple places. This can lead to inconsistencies and potential issues if the parameter is not a valid number. It's more robust to parse and validate it once at the beginning of the handler. After this change, you can use thehostIdvariable directly as a number throughout the function, removing the need forNumber(hostId)andparseInt(hostId).@@ -181,0 +188,4 @@`Exported host configuration for ${host.name || host.username}@${host.ip}`,);} catch (error) {toast.error(t("hosts.failedToExportHost"));The
actualAuthTypeparameter is passed to theperformExportfunction but is no longer used within its body. Removing it will clean up the code. You will also need to update the call sites for this function inhandleExport.