dennii/Termix
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 22 Wiki Activity

Feature/german language support #374

Merged
P3RF3CTION merged 19 commits from feature/german_language_support into dev-1.7.3 2025-10-07 20:32:32 +00:00
Conversation 3 Commits 19 Files Changed 18 +1593 -80
P3RF3CTION commented 2025-10-07 15:30:34 +00:00 (Migrated from github.com)
Copy Link

Overview

Short summary of what this PR does

  • Added: /src/locales/de/translation.json
  • Updated: /src/locales/en/translation.json
  • Updated: /src/locales/zh/translation.json

Changes Made

Added German Language Support to Termix
Added the German language localisation to en and zh as well a new translation.json for de (german)

Related Issues

Checklist

  • Code follows project style guidelines
  • Supports mobile and desktop UI/app (if applicable)
  • I have read Contributing.md
# Overview _Short summary of what this PR does_ - [x] Added: /src/locales/de/translation.json - [x] Updated: /src/locales/en/translation.json - [x] Updated: /src/locales/zh/translation.json # Changes Made _Added German Language Support to Termix_ Added the German language localisation to en and zh as well a new translation.json for de (german) # Related Issues - Related to Termix-SSH/Support#59 # Checklist - [x] Code follows project style guidelines - [ ] Supports mobile and desktop UI/app (if applicable) - [x] I have read [Contributing.md](https://github.com/LukeGus/Termix/blob/main/CONTRIBUTING.md)
gemini-code-assist[bot] commented 2025-10-07 15:30:49 +00:00 (Migrated from github.com)
Copy Link

Summary of Changes

Hello @P3RF3CTION, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds full German language support to the Termix application, including a new translation file and updates to existing language configurations. It also includes minor dependency updates.

Highlights

  • Intent: This pull request introduces German language support to the Termix application, making the user interface and messages available in German.
  • Key Changes: - Added new German translation file: A new file src/locales/de/translation.json has been added, containing a comprehensive set of German translations for various application sections including credentials, SSH tools, file manager, terminal, server statistics, authentication, and more.
  • Updated existing translation files: The src/locales/en/translation.json and src/locales/zh/translation.json files were updated to include 'German' as an available language option.
  • Dependency updates: The package-lock.json file was updated, incrementing the project version from 1.7.0 to 1.7.2 and adjusting peer dependency flags for various packages, likely due to a general dependency refresh.
  • Reviewer Notes: Reviewers should focus on the accuracy and completeness of the German translations in src/locales/de/translation.json. Additionally, verify that the new language option is correctly integrated into the application's language selection mechanism and that the dependency updates do not introduce any regressions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩︎

## Summary of Changes Hello @P3RF3CTION, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds full German language support to the Termix application, including a new translation file and updates to existing language configurations. It also includes minor dependency updates. ### Highlights * **Intent**: This pull request introduces German language support to the Termix application, making the user interface and messages available in German. * **Key Changes**: - **Added new German translation file**: A new file `src/locales/de/translation.json` has been added, containing a comprehensive set of German translations for various application sections including credentials, SSH tools, file manager, terminal, server statistics, authentication, and more. - **Updated existing translation files**: The `src/locales/en/translation.json` and `src/locales/zh/translation.json` files were updated to include 'German' as an available language option. - **Dependency updates**: The `package-lock.json` file was updated, incrementing the project version from `1.7.0` to `1.7.2` and adjusting `peer` dependency flags for various packages, likely due to a general dependency refresh. * **Reviewer Notes**: Reviewers should focus on the accuracy and completeness of the German translations in `src/locales/de/translation.json`. Additionally, verify that the new language option is correctly integrated into the application's language selection mechanism and that the dependency updates do not introduce any regressions. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
ZacharyZcR commented 2025-10-07 15:32:06 +00:00 (Migrated from github.com)
Copy Link

Wow, that's great. Thank you for your contribution.😘

Wow, that's great. Thank you for your contribution.😘
👍 1
gemini-code-assist[bot] (Migrated from github.com) reviewed 2025-10-07 15:32:31 +00:00
gemini-code-assist[bot] (Migrated from github.com) left a comment
Copy Link

Code Review

This pull request adds German language support to the application by introducing a new translation file and updating existing ones. This is a great addition for German-speaking users.

However, the implementation is incomplete. The new German language (de) has not been registered in the i18next configuration file (src/i18n/i18n.ts). Without this, the application will not be able to load and use the new translations. You need to import the German translation file and add de to the supportedLngs array and the resources object.

Additionally, I've found a few areas in the German translation file that could be improved for clarity and correctness. Please see my detailed comments below.

## Code Review This pull request adds German language support to the application by introducing a new translation file and updating existing ones. This is a great addition for German-speaking users. However, the implementation is incomplete. The new German language (`de`) has not been registered in the i18next configuration file (`src/i18n/i18n.ts`). Without this, the application will not be able to load and use the new translations. You need to import the German translation file and add `de` to the `supportedLngs` array and the `resources` object. Additionally, I've found a few areas in the German translation file that could be improved for clarity and correctness. Please see my detailed comments below.
src/locales/de/translation.json
@@ -0,0 +1,1385 @@
{
gemini-code-assist[bot] (Migrated from github.com) commented 2025-10-07 15:32:30 +00:00
Copy Link

medium

The question in this translation is grammatically incorrect as it's missing a verb. It should be "...aus Ordner "{{folder}}" entfernen möchten?".

        "confirmRemoveFromFolder": "Sind Sie sicher, dass Sie \"{{name}}\" aus Ordner \"{{folder}}\" entfernen möchten? Die Zugangsdaten werden in den Bereich \"Nicht kategorisiert\" verschoben.",
![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) The question in this translation is grammatically incorrect as it's missing a verb. It should be "...aus Ordner \"{{folder}}\" entfernen möchten?". ```suggestion "confirmRemoveFromFolder": "Sind Sie sicher, dass Sie \"{{name}}\" aus Ordner \"{{folder}}\" entfernen möchten? Die Zugangsdaten werden in den Bereich \"Nicht kategorisiert\" verschoben.", ```
gemini-code-assist[bot] (Migrated from github.com) commented 2025-10-07 15:32:30 +00:00
Copy Link

medium

The phrase "Teilen Sie sie diese mit uns" is redundant. "Teilen Sie diese mit uns" or "Teilen Sie sie mit uns" would be grammatically correct.

        "shareIdeas": "Haben Sie Ideen, was als nächstes für SSH-Tools kommen sollte? Teilen Sie diese mit uns"
![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) The phrase "Teilen Sie sie diese mit uns" is redundant. "Teilen Sie diese mit uns" or "Teilen Sie sie mit uns" would be grammatically correct. ```suggestion "shareIdeas": "Haben Sie Ideen, was als nächstes für SSH-Tools kommen sollte? Teilen Sie diese mit uns" ```
gemini-code-assist[bot] (Migrated from github.com) commented 2025-10-07 15:32:31 +00:00
Copy Link

medium

The term "Herunterladen-Update" is not natural German. For a button label, "Update herunterladen" would be more appropriate.

        "downloadUpdate": "Update herunterladen",
![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) The term "Herunterladen-Update" is not natural German. For a button label, "Update herunterladen" would be more appropriate. ```suggestion "downloadUpdate": "Update herunterladen", ```
gemini-code-assist[bot] (Migrated from github.com) commented 2025-10-07 15:32:31 +00:00
Copy Link

medium

This sentence is incomplete. Based on the context of other keys, it seems like it should direct the user to Discord.

        "checkDockerLogs": "Überprüfen Sie Ihre Docker-Protokolle auf den Fehlergrund und treten Sie dem Discord bei",
![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) This sentence is incomplete. Based on the context of other keys, it seems like it should direct the user to Discord. ```suggestion "checkDockerLogs": "Überprüfen Sie Ihre Docker-Protokolle auf den Fehlergrund und treten Sie dem Discord bei", ```
gemini-code-assist[bot] (Migrated from github.com) commented 2025-10-07 15:32:31 +00:00
Copy Link

medium

The English word "Logs" is used alongside its German translation "Protokollen". For consistency, it's better to only use the German term.

        "resetCodeDesc": "Geben Sie Ihren Benutzernamen ein, um einen Code zum Zurücksetzen des Passworts zu erhalten. Der Code wird in den Docker-Container-Protokollen angezeigt.",
![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) The English word "Logs" is used alongside its German translation "Protokollen". For consistency, it's better to only use the German term. ```suggestion "resetCodeDesc": "Geben Sie Ihren Benutzernamen ein, um einen Code zum Zurücksetzen des Passworts zu erhalten. Der Code wird in den Docker-Container-Protokollen angezeigt.", ```
gemini-code-assist[bot] (Migrated from github.com) commented 2025-10-07 15:32:31 +00:00
Copy Link

medium

This sentence is incomplete. Based on the English version ("Configure external identity provider for OIDC/OAuth2 authentication."), it should specify what is being configured.

        "configureExternalProvider": "Konfigurieren Sie den externen Identitätsanbieter für die OIDC/OAuth2-Authentifizierung.",
![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg) This sentence is incomplete. Based on the English version ("Configure external identity provider for OIDC/OAuth2 authentication."), it should specify what is being configured. ```suggestion "configureExternalProvider": "Konfigurieren Sie den externen Identitätsanbieter für die OIDC/OAuth2-Authentifizierung.", ```
Sign in to join this conversation.
Reviewers
No Reviewers
gemini-code-assist[bot]
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 security
Questions about network security
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dennii
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dennii/Termix#374
Delete Branch "feature/german_language_support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?