dennii/Termix
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases 22 Wiki Activity

fix: add shell creation timeout and improve error handling #489

Merged
ZacharyZcR merged 1 commits from fix/connection-loop into dev-1.10.1 2026-01-12 07:30:13 +00:00
Conversation 0 Commits 1 Files Changed 1 +58
ZacharyZcR commented 2026-01-11 11:25:46 +00:00 (Migrated from github.com)
Copy Link

Summary

  • Add 15-second timeout for shell creation to prevent silent failures
  • Improve error messages when connection closes during shell initialization
  • Add logging for shell creation start, timeout, and close events
  • Call cleanupSSH when shell creation fails with error

Root cause: When SSH connection succeeds but shell creation fails (server rejects shell request or doesn't respond), the frontend receives no notification and enters a reconnection loop until max attempts reached.

Changes:

  1. shellTimeout - If shell callback not received within 15s, send error and cleanup
  2. sshConn.on("close") - Detect close during shell init and send specific error message
  3. Added cleanupSSH() call on shell error to properly close connection

Related to #385

## Summary - Add 15-second timeout for shell creation to prevent silent failures - Improve error messages when connection closes during shell initialization - Add logging for shell creation start, timeout, and close events - Call cleanupSSH when shell creation fails with error **Root cause**: When SSH connection succeeds but shell creation fails (server rejects shell request or doesn't respond), the frontend receives no notification and enters a reconnection loop until max attempts reached. **Changes**: 1. `shellTimeout` - If shell callback not received within 15s, send error and cleanup 2. `sshConn.on("close")` - Detect close during shell init and send specific error message 3. Added `cleanupSSH()` call on shell error to properly close connection Related to #385
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 docker
Pull requests that update docker code
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 question
Further information is requested
 security
Questions about network security
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dennii
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dennii/Termix#489
Delete Branch "fix/connection-loop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?