dennii/dbgate
1
0
Fork 0
mirror of https://github.com/DeNNiiInc/dbgate.git synced 2026-05-02 11:23:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

save table structure uses transaction

Browse Source
This commit is contained in:
Jan Prochazka
2023-02-05 19:24:22 +01:00
parent e9a01a1ffd
commit cd000098f1
5 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/tools/src/diffTools.ts
View File

@@ -507,9 +507,7 @@ export function getAlterTableScript(
const plan = createAlterTablePlan(oldTable, newTable, opts, wholeOldDb, wholeNewDb, driver); const plan = createAlterTablePlan(oldTable, newTable, opts, wholeOldDb, wholeNewDb, driver);
const dmp = driver.createDumper({ useHardSeparator: true }); const dmp = driver.createDumper({ useHardSeparator: true });
if (!driver.dialect.disableExplicitTransaction) dmp.beginTransaction();
plan.run(dmp); plan.run(dmp);
if (!driver.dialect.disableExplicitTransaction) dmp.commitTransaction();
return { return {
sql: dmp.s, sql: dmp.s,
recreates: plan.recreates, recreates: plan.recreates,
@@ -526,9 +524,7 @@ export function getAlterDatabaseScript(
) { ) {
const plan = createAlterDatabasePlan(oldDb, newDb, opts, wholeOldDb, wholeNewDb, driver); const plan = createAlterDatabasePlan(oldDb, newDb, opts, wholeOldDb, wholeNewDb, driver);
const dmp = driver.createDumper({ useHardSeparator: true }); const dmp = driver.createDumper({ useHardSeparator: true });
if (!driver.dialect.disableExplicitTransaction) dmp.beginTransaction();
plan.run(dmp); plan.run(dmp);
if (!driver.dialect.disableExplicitTransaction) dmp.commitTransaction();
return { return {
sql: dmp.s, sql: dmp.s,
recreates: plan.recreates, recreates: plan.recreates,

1
packages/types/dialect.d.ts vendored
View File

@@ -32,7 +32,6 @@ export interface SqlDialect {
dropCheck?: boolean; dropCheck?: boolean;
dropReferencesWhenDropTable?: boolean; dropReferencesWhenDropTable?: boolean;
disableExplicitTransaction?: boolean;
predefinedDataTypes: string[]; predefinedDataTypes: string[];

2
packages/web/src/tabs/CompareModelTab.svelte
View File

@@ -277,7 +277,7 @@
const conid = $values?.targetConid; const conid = $values?.targetConid;
const database = $values?.targetDatabase; const database = $values?.targetDatabase;
const resp = await apiCall('database-connections/run-script', { conid, database, sql }); const resp = await apiCall('database-connections/run-script', { conid, database, sql, useTransaction: true });
const { errorMessage } = resp || {}; const { errorMessage } = resp || {};
if (errorMessage) { if (errorMessage) {
showModal(ErrorMessageModal, { title: 'Error when saving', message: errorMessage }); showModal(ErrorMessageModal, { title: 'Error when saving', message: errorMessage });

2
packages/web/src/tabs/TableStructureTab.svelte
View File

@@ -131,7 +131,7 @@
} }
async function handleConfirmSql(sql, createTableName) { async function handleConfirmSql(sql, createTableName) {
const resp = await apiCall('database-connections/run-script', { conid, database, sql }); const resp = await apiCall('database-connections/run-script', { conid, database, sql, useTransaction: true });
const { errorMessage } = resp || {}; const { errorMessage } = resp || {};
if (errorMessage) { if (errorMessage) {
showModal(ErrorMessageModal, { title: 'Error when saving', message: errorMessage }); showModal(ErrorMessageModal, { title: 'Error when saving', message: errorMessage });

1
plugins/dbgate-plugin-sqlite/src/frontend/driver.js
View File

@@ -22,7 +22,6 @@ const dialect = {
return `[${s}]`; return `[${s}]`;
}, },
anonymousPrimaryKey: true, anonymousPrimaryKey: true,
disableExplicitTransaction: true,
createColumn: true, createColumn: true,
dropColumn: true, dropColumn: true,